Validation Script

Teessider_2000 · December 6th, 2006, 10:12 AM

Hi Guys

Im fairly inexperienced with JavaScript and was wondering if anyone could give me a helping hand with a relatively simple validation script im trying to make.

Basically i am making an online survey with lots and lots of radio buttons on multiple pages, rather than validating each set of radio buttons line by line i tried to create a looping script which would check each radio button in the entire form and tell the user which questions have been unanswered.

On the first page there are 16 questions so i was hoping it would save me some time! Heres the code i have so far, needless to say, it isnt working!

function Validate(){

for (var x = 1; x <= 16; x++) // there are 16 questions
{
    for (counter = 0; counter <=2; counter++) // 3 possible answers
    {
       //each radio button starts with a 'q'
       if (page1.q[x][counter].checked)
       {
          return (true);
       }
       else
       {
          msg+="You have not answered question "[x]".\n";
          return (false);
        }
    }
    return (false);
}
}
Any help would be great, cheers in advance!

MunishBhatia · December 6th, 2006, 10:28 AM

hi
tell me where u declared variable Counter and msg

thanks......

Teessider_2000 · December 6th, 2006, 10:55 AM

I thought it was enough to declare counter in the for loop?
And the msg bit isnt quite finished yet, just need to echo it out.
I imagine the problem is the q[x] bit, i really wanted to just drop the variable x at the end of q, ie q1, q2, q3 etc but am not sure how u do that in javascript.

joefawcett · December 6th, 2006, 11:12 AM

You need someway of grouping the radio buttons by question, they should have the same name for each question so maybe you mean:
question one has radio buttons all named Q_1
question two has radio buttons all named Q_2...
If so then you need to use getElementsByName:

Code:

function getCheckedControl(groupName)
{
  var col = document.getElementsByName(groupName);
  for (var i = 0; i < col.length; i++)
  {
    if (col[i].checked) return col[i];
  }
  return null;
}

function validateRadioGroups(namePrefix, questionCount)
{
  var unansweredQuestions = "";
  for (var i = 1; i < questionCount + 1; i++)
  {
    var isAnswered = (getCheckedControl(namePrefix + i) != null);
    if (!isAnswered)
    {
      unansweredQuestions += ", " + i;  
    }
  }
  if (unansweredQuestions.length != 0)
  {
    unansweredQuestions = unansweredQuestions.substr(2)
    alert("You failed to answer question(s): " + unansweredQuestions);
  }
}

validateRadioGroups("Q_", 16);

Untested...

--

Joe (Microsoft MVP - XML)

Teessider_2000 · December 6th, 2006, 04:22 PM

Thanks Joe

I appreciate the help, but i cant understand why my code isn't working, ive been looking at it for ages, my html doesnt even seem to register using the function i made! Its not going great!

function Do_Validate(page1)
{
    var proceed = "false";
    for (var x = 1; x <= 16; x++)
    {
        for (var counter = 0; counter <= 2; counter++)
        {
            var q = "q";
            var question = q.concat(x);
            if (page1.question[counter].checked)
            {
                proceed = "true";
            }
            else
            {
                proceed = "false";
            }
        }
    }

    if (proceed != "true")
    {
        //var msg+="You have not answered question \n";
        //echo(msg);
        return false;
    }
    else
    {
        page1.submit();
    }

}
Thats the latest javascript and the source code can be found at
http://www.williamcarson.co.uk/Evalu...orm/form1.html

If anyone can cast an eye and see why its not working i would be so so grateful. Cheers.

mohan.karunanidhi · December 23rd, 2006, 02:29 AM

hi Teesider,

The code you have written is excellent except this line
if (page1.question[counter].checked)

it means you are hard coding a string

but it has to be dynamic

i tried
  var str="document."+page1;
            str+=question+"["+counter+"]";
            str+=".checked";
if (str)
{
}
[u]
even in this there is a problem!! </u>

the str is a string .but we need a boolean object to get the result from the page

if we can convert the string into a boolean then it wil be done.

I was googling a bit for that but i dont know exactly how to do it.
if you can ... tell me also
Thanks
Mohan

jafuller · December 28th, 2006, 07:56 PM

It looks like you already have the boolean in your code, you just need to return it at the end and remove the quotes from the values.

function Do_Validate(page1)
{
    var proceed = false;
    for (var x = 1; x <= 16; x++)
    {
        for (var counter = 0; counter <= 2; counter++)
        {
            var q = "q";
            var question = q.concat(x);
            if (page1.question[counter].checked)
            {
                proceed = true;
            }
            else
            {
                proceed = false;
            }
        }
    }

    if (proceed != true)
    {
        //var msg+="You have not answered question \n";
        //echo(msg);
        return false;
    }
    else
    {
        page1.submit();
    }
  return proceed;
}

Does this work for you?

mohan.karunanidhi · January 5th, 2007, 12:22 PM

If i put a statement like this then iam getting the result as "[String]"

but at the same place if i put it as

alert(typeof(page1.q1[1].checked))

i get the result as "[boolean]"

some where the value changes to string.. may be since we are using concat function... if we somehow convert the string in to a boolean variable and execute it .. it should work fine

function Do_Validate(page1)
{
    var proceed = false;
    for (var x = 1; x <= 16; x++)
    {
        for (var counter = 0; counter <= 2; counter++)
        {
            var q = "q";
            var question = q.concat(x);
      alert(typeof(page1.question[counter].checked)); if (page1.question[counter].checked)
            {
                proceed = true;
            }
            else
            {
                proceed = false;
            }
        }
    }

    if (proceed != true)
    {
        //var msg+="You have not answered question \n";
        //echo(msg);
        return false;
    }
    else
    {
        page1.submit();
    }
  return proceed;
}

Many Thanks,
Mohan