expected ';'

RoniR · February 1st, 2007, 03:31 AM

hello guys ur help is needed again
<script language="javascript" >
function ReturnUrl()
{
var url=parent.location.href; (url shoud contain that -->Forms/iframe1.aspx?country=Lebanon)
var index=url.indexOf('=');
var country=url.substr(index,url.length));
alert(country);
if (strcmp(country,'Lebanon')
{
link="Iframe1.aspx";
}
if (strcmp(country,'Jordan'))
{
link="IframeJordan.aspx";
}
if (strcmp(country,'Syria'))
{
link="iframeSyria.aspx";
}
parent.location.href=link;
}
</script>

<input type="button" value="Back to Main2" onClick="ReturnUrl()" >

it tells me that i am missing a ';' in line 15 which starts at <script language="javascript" > and an ObjectExpected on the onClick="ReturnUrl();" ...
10x in advance.(1st script i write so if i have any syntax error feel free to tell me)

vinod_yadav1919 · February 1st, 2007, 04:24 AM

Hii
Check it
1>var country=url.substr(index,url.length));
replace with
var country=url.substr(index,url.length);

2>if (strcmp(country,'Lebanon')
replace with
if (strcmp(country,'Lebanon'))

Hope this will hope you

Cheers :)

vinod

joefawcett · February 1st, 2007, 04:26 AM

Your code is missing a closing parenthesis, not sure if that's the problem, line numbers in error messages aren't always decipherable. I would have used the location.search property and the switch construct:

Code:

var sSearch = location.search;
var iIndex = sSearch.indexOf("country=");
if (iIndex > -1)
{
  var sCountry = sSearch.substr(9); //Test this!!!
  var sLink;
  switch(sCountry.toLowerCase())
  {
    case "lebanon":
      sLink = "iframe1.aspx";
      break;
    case "jordan":
      //other countries.
  }
  parent.location.href = sLink;

  }
}

The script tag should also use type="text/javascript" rather than the deprecated language attribute.

--

Joe (Microsoft MVP - XML)

RoniR · February 1st, 2007, 05:28 AM