Hi there

I've got this piece of javascript trying to validate whether the uploaded image is either a gif or jpg

function Validate(objForm)
{

    re = /^(file|C):\/\/\S+\/\S+\.(gif|jpg)$/i

    if (re.test(objForm.ImgURL.value)) {
    document.chgImg.src = objForm.ImgURL.value
    }
    else {
    alert("Image needs to be a gif or jpg.")
    objForm.ImgURL.focus()
    objForm.ImgURL.select()
    return false;
    }

However, it only gets to the alert - "Image needs to be a gif or jpg" and no further even when I do try to upload a jpg.

Can anyone point me in the right direction as to how to get this working right?

thanks

Adam

Seems to work for me. Show us a bit more code and html. You should return true if the file name passes the test and maybe change the last part to (gif|jpg|jpeg) though.

--

Joe

Hi Joe

Here's the full script:

</SCRIPT>
<script language = "javascript">

function Validate(objForm)
{

    re = /^(file|C):\/\/\S+\/\S+\.(gif|jpg)$/i

    if (re.test(objForm.ImgURL.value)) {
    document.chgImg.src = objForm.ImgURL.value
    }
    else {
    alert("Image needs to be a gif or jpg.")
    objForm.ImgURL.focus()
    objForm.ImgURL.select()
    return false;
    }

    if (objForm.N.value == "")
    {
        window.alert("Name is a required Field!");
        objForm.N.focus();
        return false;
    }

    if (objForm.E.value == "")
    {
        window.alert("Email Address is a required Field!");
        objForm.E.focus();
        return false;
    }

    if (objForm.E.value.indexOf("@", 0) == -1 || (objForm.E.value.indexOf("@", 0) != objForm.E.value.lastIndexOf("@", (objForm.E.value.length - 1))) || objForm.E.value.indexOf(".", 0) == -1)
    {
        window.alert("Email Address must be a valid Email Address!");
        objForm.E.focus();
        return false;
    }

    return true;
}
// -->
</script>


thanks alot

Adam

What is in ImgURL element? For your regular expression to work the path must be in the form:
c://myFolder/myFile.gif
It must have exactly one folder and have forward slashes as delimiters.



--

Joe

Hi Joe

This is the form element code:

<input name="ImgURL" type="file" class="box" id="ImgURL">

Can't see the wood from the trees at the moment as to how it needs to change to make it work.

thanks

Adam

Here you have an alternative form to do it:):

 //URL of the selected file
 var tipo = objForm.ImgURL.value;
 tipo = tipo.substring(tipo.indexOf(".")+1);
 //Set of the types of archives that can select
 var tipos = new Array("gif","jpg","jpeg");
 var isImg = false;
 for(var i= 0; i<tipos.length; i++) {
     if(tipo == tipos[i]) {
        var oImagen = document.getElementById("chgImg");
        oImagen.src = objForm.ImgURL.value
    isImg = true;
    break;
     }
 }
 if(!isImg){
    alert("Image needs to be a gif or jpg.");
    objForm.ImgURL.focus()
    objForm.ImgURL.select()
    return false;
 }

I hope that it serves to you as aid.

Great, thanks alot - will give it a go.

Adam

Thanks alot - all good and working now!