problems with JavaScript Code

red_fiesta · February 16th, 2007, 06:35 AM

i am having problems making this work...
please help..

Code:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

Code:

<html xmlns="http://www.w3.org/1999/xhtml">
<head>



<script language="JavaScript"><!--
function VerifyData() {
    for (var i=0;i<2;i++) {
        if (document.testa[i].checked)
            return true;
    }
    alert('You must chose a template for section testa');
    return false;

    for (var i=0;i<2;i++) {
        if (document.testb[i].checked)
            return true;
    }
    alert('You must chose a template for section testb');
    return false;
}


//-->




</script>




</head>
<body>
 
<form name="Template" method="post" action="next.asp"  onSubmit="return VerifyData();">


         a<input type="radio" name="testa" id="testa" value="1" /> 


         b<input type="radio" name="testa" id="testa" value="3" /> 

<br />

            c<input type="radio" name="testb" id="testb" value="1" /> 


         d<input type="radio" name="testb" id="testb" value="3" /> 
<br />

        <input type="submit" value="go" />

         </form>

</body>
</html>

joefawcett · February 16th, 2007, 07:00 AM

There are two obvious mistakes. Firstly you can't access radio groups by index. You need to use getElementsByName('testa') to get a collection of the relevant group and then loop through this collection as you have done:

Code:

var colGroup = getElementsByName('testa');
for (var i = 0; i < colGroup.length; i++)
{
  if (colGroup.checked) return true;
}

The second error is that your function will always return after testing the first group. You need to change it so that it returns false if it fails but if it succeeds then does the second check against the other group.

--

Joe (Microsoft MVP - XML)

red_fiesta · February 16th, 2007, 07:20 AM

Hi,

I have tried to use your code to get it to work..

but now i get the error message whether one radio is selected or not..

Code:

<script language="JavaScript"><!--
function VerifyData() {




var colGroup = document.getElementsByName('testa');
for (var i = 0; i < colGroup.length; i++) {
  if (colGroup.checked) 
  return true;
  }
  alert('You must chose a template for section 1');
    return false;
}


//-->




</script>

red_fiesta · February 16th, 2007, 07:26 AM

Ok this works for one..

<script language="JavaScript">

</script>

so how then would i make it work for 2..

when i cant do this..

<script language="JavaScript">

</script>

joefawcett · February 16th, 2007, 08:57 AM

Sorry missed the [i] bit.

--

Joe (Microsoft MVP - XML)

error46146 · March 6th, 2007, 04:44 PM

Why did you type this?

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

What is it for?