syntax error

Adam H-W · October 30th, 2003, 07:53 AM

Hi there

I'm getting a syntax error with this code right at the bottom of the script where it's marked in red but I can't seem to see if myself. Any help would be greatly appreciated.

<script language="javascript" type="text/javascript">

function toggleCheck(thisField) {
checkSet = eval("document.frm_bk."+ thisField)
checkSet.checked = !(checkSet.checked)
    }
function toggleRadio(thisField, thisValue) {
radioSet = eval("document.frm_bk."+ thisField)
    }

for (i=0;i<radioSet.length;i++) {
    if (radioSet[i].value ==
    thisValue)
    radioSet[i].checked = true
    }
}
Thanks

Adam

Jonax · October 30th, 2003, 08:01 AM

You have one more closing bracket than opening.

I think the one you should remove is the one following the line

Code:

radioSet = eval("document.frm_bk."+ thisField)

joefawcett · October 30th, 2003, 08:13 AM

As a side issue using eval is very poor practice. It creates a new script engine each time it is used which can slow execution times considerably. Instead of:

Code:

checkSet = eval("document.frm_bk."+ thisField)

try

Code:

checkSet = document.frm_bk[thisField];

--

Joe

Adam H-W · October 30th, 2003, 10:23 AM

thanks guys - works a treat with your suggestions!