Delete query not working

Mitch · November 15th, 2005, 10:23 PM

I am trying to fix my delete function that deletes a string of text that may or may not have single, double quotes, pound signs etc.

Code:

function delete_bm($user, $url)
{
  // delete one text string from the database NOT a url as would be suggested
  if (!($conn = db_connect()))
    return false;

   // delete the Item
  if (!mysql_query( "delete from XMAS_WISH_LIST
                       where username='$user' and XMAS_ITEM='".mysql_escape_string($url)."'"))
    return false;
  return true;  
}

When I run this on my web page, I don't get an error, it just does not delete the item that I am passing it, like the following: "test" (with quotes).

Any suggestions?

Mitch

richard.york · November 16th, 2005, 08:09 AM

Do you have magic_quotes_gpc activated? If so you don't need mysql_escape_string().

If not, try more aggressive error reporting.

Output the query, so you can see if there is something erroneous.

Code:

echo "delete from XMAS_WISH_LIST
                       where username='$user' and XMAS_ITEM='".mysql_escape_string($url)."'";

And output any mysql errors.

Code:

$query = mysql_query(
    "DELETE
       FROM XMAS_WISH_LIST
      WHERE username  = '$user' 
        AND XMAS_ITEM = '".mysql_escape_string($url)."'"
);

if (!$query)
{
    echo mysql_errno().': '.mysql_error()."\n";
    return false;
}
else
{
    return true;
}

HTH!

Regards,
Rich

--
[http://www.smilingsouls.net]
Mail_IMAP: A PHP/C-Client/PEAR solution for webmail
Author: Beginning CSS: Cascading Style Sheets For Web Design

Mitch · November 17th, 2005, 03:15 PM

It looks like when I click on the "submit" button it is sending everything up to the quote, so I am not sure what to do to correct that.

Mitch

Christoff · December 30th, 2005, 08:02 AM

Did you check your variable scope?

If $conn is the connection you use, you must set which $conn you're going to use, the one in the current function, or a globally defined one?

function delete_bm($user, $url)
{
global $conn;
etc etc etc...

anshul · January 4th, 2006, 08:00 AM

May be, user that is connected to MySQL database via PHP script may not have delete permission ..!

`~@#\^%&*/\.<.\/-|+|_!:;..=?>
Students' finances