Problems with regular expressions

netcr1me · June 15th, 2004, 11:12 AM

This code below is used for making urls in my forum clickable.. but i also want to have a [img][/img] function which doesnt work because if i write http://www.text.com/pic.jpg the code below as already turned it into: [img]<a href="http://www.text.com/pic.jpg">http://www.text.com/pic.jpg</a>[/img]

.. both my functions crashes with one and another. How can i modify $prefix so that it doesnt react to a url which has [img] infront of it?

URL Replacer

Code:

    $prefix = '(http|https|ftp|telnet|irc|news|gopher|file|wais)://';
    $pureUrl = '([[:alnum:]/\n+-=%&:_.~?]+[#[:alnum:]+]*)';
    $myReplacement = eregi_replace('([[:space:]]|^)(www)', '\\1http://\\2', $myReplacement);
    $myReplacement = eregi_replace($prefix . $pureUrl, '<a href="\\1://\\2" target="_blank">\\1://\\2</a>', $myReplacement);

Moharo · July 15th, 2004, 02:04 PM

hey there

to solve this problem, you should not use just eregi_replace() function, because here the [img][/img] will not work. instead use perl compatible regexp functions like: preg_match_all() or preg_replace().... you will have to have a further insight into this because i'm not too good with regular expressions. i suggest you check out www.php.net

this is how i see the solution (pseudo code)

1) scan for [img][/img],[link][/link] etc...
2) for each type, extract attributes like "src" for image and "href" for link and then call appropriate preg_replace() function which will convert [link][/link] to <a></a>, and so forth and so on....

this might sound little bit confusing but it's better than nothing :D

peace

www.campusgrind.com the college portal

Moharo · July 19th, 2004, 02:42 PM

hey there

i found the solution to your problem.... to overcome these problems you had, here's what i came up with. and so, for custom link tags:

[link=http://www.anything.com]any thing here[/link]

write this:

$message = $_POST["message"]; //usually textarea sent thru post method
$message = preg_replace("/\[link=(.*?)\](.*?)\[\/link\]/s","<a href=\"\\1\" target=\"_blank\">\\2</a>",$message);

where $message is a textarea where the user inputs his custom tags or whatever.

for custom image tags:

http://www.anything.com

write this:

$message = preg_replace("/\[img\](.*?)\[\/img\]/s","<img src=\"\\1\" border=\"0\">",$message)

hope that helped you :D

www.campusgrind.com the college portal