for loops from within foreach

richard.york · September 29th, 2003, 11:23 PM

The following is a complete test script adapted from a class that I'm developing. The object of the script is to update x and y coordinates for absolutely positioning an image, in this case onto a calender. I've been through this code again and again and again and cannot figure out why the 'for' statements do not fire. Nothing between the for statements executes or outputs. The $y coordinate updates as it should but the value of $x does not change. There has to be something wrong with my for loop logic. But I can't see what it is.
Maybe a new set of eyes will help!

Thanks in advance!
: )
Rich

Code:

<?php

        function build_icons()
        {

            $icon[29] = 'star.png';
            $icon[34] = 'star.png';            

            $offset_left = (int) 65;
            $offset_top  = (int) 50;

            if (isset($icon) && is_array($icon))
            {    

                foreach($icon as $i => $file)
                {
                    # Return x and y to default values
                    $x = (int) 35;
                    $y = (int) 125;

                    # Range 0-6 is the first row of the calender
                    if ($i >= 0 && $i <= 6)
                    {

                        for($d = 0, $f = 0; $f == $i; $d++, $f++)
                        {
                            if ($d > 0) $x = ($x + ($offset_left * $d));
                        }

                    }

                    else if ($i >= 7 && $i <= 13)
                    {

                        $y = ($y + $offset_top);
                        for($d = 0, $f = 7; $f == $i; $d++, $f++)
                        {
                            if ($d > 0) $x = ($x + ($offset_left * $d));
                        }

                    }

                    else if ($i >= 14 && $i <= 20)
                    {

                        $y = ($y + ($offset_top * 2));
                        for($d = 0, $f = 14; $f == $i; $d++, $f++)
                        {
                            if ($d > 0) $x = ($x + ($offset_left * $d));
                        }

                    }

                    else if ($i >= 21 && $i <= 27)
                    {

                        $y = ($y + ($offset_top * 3));
                        for($d = 0, $f = 21; $f == $i; $d++, $f++)
                        {
                            if ($d > 0) $x = ($x + ($offset_left * $d));
                        }

                    }

                    else if ($i >= 28 && $i <= 34)
                    {

                        $y = ($y + ($offset_top * 4));
                        for($d = 0, $f = 28; $f == $i; $d++, $f++)
                        {
                            if ($d > 0) $x = ($x + ($offset_left * $d));
                        }

                    }

                    else if ($i >= 35 && $i <= 41)
                    {

                        $y = ($y + ($offset_top * 5));
                        for($d = 0, $f = 35; $f == $i; $d++, $f++)
                        {
                            if ($d > 0) $x = ($x + ($offset_left * $d));
                        }

                    }

                    echo "<img src='images/calender/icons/{$file}' style='position: absolute; top: {$y}px; left: {$x}px; z-index: 99; width: 25px; height: 25px;' />";

                }

            } else {

                echo "Error: icon is not an array or is not set";            

            }

        }

        build_icons();

?>

:::::::::::::::::::::::::::::::::
Smiling Souls
http://www.smilingsouls.net
:::::::::::::::::::::::::::::::::

richard.york · September 30th, 2003, 01:05 AM

I tried writing several variations of this code in different test scripts. And not a single one of them outputs anything.

Is this a bug? Or simply not allowed?

Thanks,
: )
Rich

Code:

function foo()
{
    $foo[1] = 'test1';
    $foo[2] = 'test2';    

    foreach($foo as $key => $value)
    {

        for($d = 0; $d == 10; $d++) {echo $d;}

    }

}

function foo2()
{
    $foo[1] = 'test1';
    $foo[2] = 'test2';    

    foreach($foo as $key => $value)
    {

        loop_it();

    }

}

function loop_it()
{
    for($d = 0; $d == 10; $d++) {echo $d;}            
}

$foo[1] = 'test1';
$foo[2] = 'test2';

foreach($foo as $key => $value)
{

    loop_it();

}

:::::::::::::::::::::::::::::::::
Smiling Souls
http://www.smilingsouls.net
:::::::::::::::::::::::::::::::::

richard.york · September 30th, 2003, 01:40 AM

OK after a few hours of pulling out my hair I realized the 'condition' of the statement wasn't ever being met. For some reason I assumed that when that condition was met it would break iteration. And at last I see! Its been a long day : )

:::::::::::::::::::::::::::::::::
Smiling Souls
http://www.smilingsouls.net
:::::::::::::::::::::::::::::::::

nikolai · September 30th, 2003, 01:14 PM

Yeah, Rich -- sorry I didn't get to it earlier. When you have a condition in a loop, the loop iterates only when that condition is true.

for($i = 0; $i == 10; ++$i) {...}

will NEVER iterate because before the first iteration, the condition (1 == 10) will be false, and the loop will terminate.

If you want to iterate 10 times, the convention is to use:

for($i = 0; $i < 10; ++$i)

Take care,

Nik
http://www.bigaction.org/

richard.york · October 2nd, 2003, 12:19 AM

Thanks Nik!
I sure could have used your insight the other night.
I was so fixated on when I wanted the mathematical operations preformed on variable $x that I had momentary amnesia regarding the premise of conditional statements in loop structures. I felt pretty stupid when I realized what I was trying to do! lol :D

:::::::::::::::::::::::::::::::::
Smiling Souls
http://www.smilingsouls.net
:::::::::::::::::::::::::::::::::

nikolai · October 2nd, 2003, 01:54 AM

No problem. It's nothing to feel stupid about -- I've never worked on a project where I didn't have at least one really obvious error in my code that took way too long to find. One of the more frequent ones is a missing = in my conditionals:

echo "\$foo is [[$foo]]\n";
if ($foo = "Hello, world")
{
echo "it's Hello, world!";
}

I would always get confused when my output would be:

$foo is [[I love pizza]]
it's Hello, world!

Take care,

Nik
http://www.bigaction.org/