I need help in writing a query.

The query should get top 10 items and their values from current year and the values for the same items from previous year table.

I was able to write the code for 1st part that gets values from 1st table but I don't know how to get the values from 2nd table.

The 2 tables does not have any primary/foreign key relations. Both tables have same structure and same columns.



I am attaching some images below to give more information.

Image of results from my query.
http://www.fiu.edu/%7Eatmakurk/ustrade/7_1.jpg

Image of how the final output should look like.
http://www.fiu.edu/%7Eatmakurk/ustrade/7_2.jpg

The Store Procedure code is:

ALTER Procedure [dbo].[free_customsHS4](
@TblName1 varchar(20),
@TblType varchar(20),
@District varchar(6),
@Month varchar(3)
)


AS
Begin
SET NOCOUNT ON;

Declare @SQuery nvarchar(3000)
set @TblName1 = '[' + @TblName1 + ']'
set @TblType = '[' + @TblType + ']'


SELECT @SQuery = 'select top 10 a.commodity1 as HS4, b.descrip_1 as Description,
sum(a.all_val_mo) as [Amount],

(sum(a.all_val_mo)/(select Sum(a.all_val_mo) FROM ' + @TblName1 + 'a
where a.stat_month <=' + @Month + ' and a.district=' + @District +'))*100 as [% Share]

FROM ' + @TblName1 + ' a left outer join ' + @TblType + ' b on a.commodity1=b.commodity1
where a.stat_month <=' + @Month + ' and a.district=' + @District +'
Group by a.commodity1, b.descrip_1
order by [Amount] desc'

EXEC sp_executesql @SQuery
END

hi there.. if they have the same structure they have key fields that are the same. Maybe the relations no exists in the database, but the data is relationated anyway.. both of your table has a hs4 field that look the same. Can you just join the table with that field???

HTH

Gonzalo

When I do a Join, the results are completely different. I am not sure I am doing the join right.


I was playing around with my code and I was able to calculate Amount2 for previous year but I am still stuck at Share2. The code after modification is below: (I pass 2 table names and 2 where conditions)


SELECT @SQuery = 'select top 10 a.commodity1 as HS4, sum(a.all_val_mo) as [Amount1],

(sum(a.all_val_mo)/(select Sum(a.all_val_mo) FROM ' + @TblName1 + 'a where a.stat_month <=' + @Month + ' and a.district=' + @District +'))*100 as [% Share1],

(select sum(b.all_val_mo) from '+ @TblName2 +' b where b.commodity1=a.commodity1 and b.stat_month <=' + @Month + ' and b.district=' + @District +') as [Amount2]

--(sum(b.all_val_mo)/(select Sum(b.all_val_mo) FROM ' + @TblName2 + 'b where b.commodity1=a.commodity1 and

--b.stat_month <=' + @Month + ' and b.district=' + @District +'))*100 as [% Share2]

from '+ @TblName1 + 'a where a.stat_month <=' + @Month + ' and a.district=' + @District +'

Group by a.commodity1 order by [Amount1] desc'

EXEC sp_executesql @SQuery
END



The results look like
http://www.fiu.edu/~atmakurk/ustrade/7-5.jpg

But that's not the result you want???



HTH

Gonzalo