error in query

capri · April 3rd, 2008, 10:58 PM

tis sp insert time in the database .if it exit in the db it rasie
error other wise it insert the new time evert time
but it give error on 2 Statement "Begin "

some one help me to recover error

CREATE PROCEDURE InsertTiming(@timing nvarchar(255))
BEGIN
  SET NOCOUNT ON;

  -- Check if timing already exists
  DECLARE @tmp nvarchar(255);
  SELECT @tmp = s_time FROM timing WHERE s_time = @timing;
  IF @tmp IS NOT NULL
  BEGIN
    raiserror(N'Timing %s already assigned',
      10,
      1,
      @timing);
  END

  -- Insert new value
  INSERT INTO timing(s_test) VALUES (@timing);
END

Jeff Moden · April 3rd, 2008, 11:18 PM

CREATE PROCEDURE InsertTiming(@timing nvarchar(255))
AS
BEGIN
  SET NOCOUNT ON;

  -- Check if timing already exists
  DECLARE @tmp nvarchar(255);
  SELECT @tmp = s_time FROM timing WHERE s_time = @timing;
  IF @tmp IS NOT NULL
  BEGIN
    raiserror(N'Timing %s already assigned',
      10,
      1,
      @timing);
  END

  -- Insert new value
  INSERT INTO timing(s_test) VALUES (@timing);
END

--Jeff Moden

capri · April 4th, 2008, 12:29 AM

i use As before begining
it give me error on

@timing

Jeff Moden · April 4th, 2008, 01:14 AM

Please... print the actual error you get so I can see things like line numbers and error codes.

--Jeff Moden

Jeff Moden · April 4th, 2008, 01:18 AM

You really need to check Books Online for syntax... in the mean time, I thing the problem is that you put parenthesis around the input paramter... remove those and you should be good to go. Also, for the sake of brevity, you can remove the outer BEGIN and the RELATED end... they are not required in SQL Server.

--Jeff Moden

Jeff Moden · April 4th, 2008, 01:27 AM

Here's how I'd write the code... dunno if the tables and column names are correct because you didn't list the CREATE TABLE statement for any of the tables...

Code:

 CREATE PROCEDURE dbo.InsertTiming 
        @Timing NVARCHAR(255)
     AS
    SET NOCOUNT ON

     IF EXISTS (SELECT S_Time FROM dbo.Timing WHERE S_Time = @Timing)
  BEGIN --Alert the operator if the timing already exists
        RAISERROR(N'Timing %s already assigned',10,1,@Timing)
    END
   ELSE
  BEGIN --Timing does not exist... insert new timing value
        INSERT INTO dbo.timing(S_Test) VALUES (@Timing)
    END

--Jeff Moden