ADO.NET

digby_dog · June 15th, 2005, 05:17 AM

I'm having trouble a bit of trouble with the code below. It was taken from a book on VB.NET.

I've highlighted the error below which is a simple IndexOutOfRange. I'm happy with the right side of the equation but I canât work out the syntax for the left hand side which I shown in red here:

myRow.Item(counter) = strCollection(counter)

Any help would be appreciated.:)

Code:

Imports System
Imports System.Object
Imports System.Data
Imports System.Collections
Imports System.Collections.Specialized
Imports System.Windows.Forms

   Private Sub Form1_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
        Dim strCollection As New StringCollection

        strCollection.Add("Dog")
        strCollection.Add("Cat")
        strCollection.Add("Sheep")
        strCollection.Add("Cow")

        Dim myDataSet As New DataSet

        Dim myTable As New DataTable
        'Add the table to the tables collection
        myDataSet.Tables.Add(myTable)

        ' Create a column
        Dim AccountsColumn As New DataColumn("Accounts")
        ' And add it to the columns collection of the table
        myDataSet.Tables(0).Columns.Add(AccountsColumn)

        'Create a row
        Dim myRow As DataRow
        ' Add a new row to the table


        Dim counter As Integer
        For counter = 0 To strCollection.Count - 1
            myRow = myDataSet.Tables(0).NewRow()
            myRow.Item(counter) = strCollection(counter) <----ERROR
            myTable.Rows.Add(myRow)
        Next
    End Sub

planoie · June 15th, 2005, 06:09 AM

I would say the problem here is that you are referencing an incremental index some the columnds of the table which you don't need to do. Basically it plays out like this:

If your string collection looks like this:

"one"
"two"
"three"

And your new datatable structure looks like this

Accounts
--------

then what that loop is trying to do is this:

Code:

What you want:   What you are getting:

Accounts         Accounts
--------         --------
"one"            "one"
"two"                      "two"
"three"                           "three"

Every column assignment after the first one is trying to assign to a non-existing column. You don't need to index the Items of the row, just use the first one (which is the first and only column you added to the table):

myRow.Item(0) = strCollection(counter)

-Peter

digby_dog · June 16th, 2005, 08:28 AM

Thanks for your reply.