hi there.. if userid and password are string (or char) types shouldn't be surrounded by ' ?????

i mean...

"insert into login (UserId, Password) values ('@UserId', '@Password')"

HTH

Gonzalo

No no,Values of userid and password r taken from textboxes txtUserName.text and txtPassword.text

again..

char values should be between ' when you pass it in a query... it doesn't matter how you build the query...

HTH

Gonzalo

yes, agreed.

--Stole this from a moderator

I will only tell you how to do it, not do it for you.
Unless, of course, you want to hire me to do work for you.