hello

I would like to know if I can make this more efficency, rather then call a template for each time.
my xsl:

<xsl:template name="CA-graph">
<xsl:param name="CA_entity"/>
<xsl:param name="i"/>
   <xsl:if test="count(/etd/entities/entity/data[@class=$CA_entity]) = 0">
    <xsl:attribute name = "{concat('v',$i)}">
        <xsl:value-of select="$CA_entity"/>
    </xsl:attribute>
   </xsl:if>
</xsl:template>


<xsl:call-template name="CA-graph">
  <xsl:with-param name="CA_entity" select="'activity'"/>
  <xsl:with-param name="i" select="'2'"/>
</xsl:call-template>
<xsl:call-template name="CA-graph">
  <xsl:with-param name="CA_entity" select="'program'"/>
  <xsl:with-param name="i" select="'3'"/>
</xsl:call-template>
<xsl:call-template name="CA-graph">
  <xsl:with-param name="CA_entity" select="'client_ip'"/>
  <xsl:with-param name="i" select="'4'"/>
</xsl:call-template>
<xsl:call-template name="CA-graph">
  <xsl:with-param name="CA_entity" select="'user_name'"/>
  <xsl:with-param name="i" select="'5'"/>
</xsl:call-template>
<xsl:call-template name="CA-graph">
  <xsl:with-param name="CA_entity" select="'application'"/>
  <xsl:with-param name="i" select="'6'"/>
</xsl:call-template>

simply I would like to write it in a simple and nice way instead of calling each time the template with different CA_entity and different i.
one restriction - since there is an if in the template CA-graph, it could be that some of the call template will not pass the if.

Thanks

The best way to improve the efficiency of this code is probably to replace the expression /etd/entities/entity/data[@class=$CA_entity] with key('k', $CA_entity), having first declared

<xsl:key name="k" match="/etd/entities/entity/data" use="@class"/>

There's no reason to believe that the template calling should be inefficient, although of course that may be true for some implementations. You may not like the verbosity of the template calls, but that's a different matter. In 2.0 you can replace these with function calls.

Michael Kay
http://www.saxonica.com/
Author, XSLT Programmer's Reference and XPath 2.0 Programmer's Reference

thank you very much.
if you say there is not efficency problem, so I dont see a reason to change.

Kfir