I already have a piece of code which is working fine

<xsl:for-each select="c:CourtAction">
  <xsl:for-each select="c:CourtCharge">
    <xsl:value-of select="i:ChargeDescriptionText"/>
     <xsl:if test="position()!=last()">,</xsl:if>
  </xsl:for-each>
</xsl:for-each>


For better readability i decided to gor for XSL:call-template. I wrote code ike this

<xsl:call-template name="datadisplay">
 <xsl:with-param name="field1" select="c:CourtAction"></xsl:with-param>
 <xsl:with-param name="field2" select="c:CourtCharge"></xsl:with-param>
 <xsl:with-param name="field3" select="i:ChargeDescriptionText"></xsl:with-param>
 <xsl:with-param name="field4" select="''"></xsl:with-param>
</xsl:call-template>


 and

<xsl:template name="datadisplay">
    <xsl:param name="node"></xsl:param>
    <xsl:param name="subnode"></xsl:param>
    <xsl:param name="element1"></xsl:param>
    <xsl:param name="element2"></xsl:param>
    <xsl:for-each select="$node">
      <xsl:for-each select="$subnode">
      <xsl:value-of select="$element1"/>
      <xsl:if test="position()!=last()">,</xsl:if>
    </xsl:for-each>
    </xsl:for-each>
</xsl:template>

but its throwing the error "Expression must evaluate to a node set. What could have gone wrong?

What you want to accomplish can probably be done by substituting the above <xsl:for-each> loop as follows:

<xsl:apply-templates select="c:CourtAction"/>

and then defining the following template:

<xsl:template match="c:CourtCharge">
  <xsl:value-of select="i:ChargeDescriptionText"/><xsl:if test="position()!=last()">,</xsl:if>
</xsl:template>


/- Sam Judson : Wrox Technical Editor -/

Thats realy good. But canu please point out what went wrong when i used call template.

Well in your working code above, each time you called xsl:for-each it changes the context object, so the inner xsl:for-each is referring to a children of the outer elements only.

In your xsl:call-template example however the context does not change within the parameters, so the second and third parameters would not select anything. Oh, and the fact that the "name" attribute between your parameters didn't match (i.e. you should have a matching xsl:with-param for each xsl:param).

/- Sam Judson : Wrox Technical Editor -/

Variables in XSLT don't hold fragments of XPath expressions, they hold values. So when you do this:

<xsl:with-param name="field1" select="c:CourtAction"></xsl:with-param>
 <xsl:with-param name="field2" select="c:CourtCharge"></xsl:with-param>
 <xsl:with-param name="field3" select="i:ChargeDescriptionText"></xsl:with-param>

the values of all three variables are sets of nodes; all the expressions are evaluated with the same context node. If the CourtCharge elements are children of the CourtAction elements, then select="c:CourtCharge" starting from this context node will select an empty set of nodes.

Michael Kay
http://www.saxonica.com/
Author, XSLT 2.0 and XPath 2.0 Programmer's Reference

Thanks fro the replies. I have one more problem when i am using applytemplate. The condition position()!=last() always evaluates false. Any reason for this and any work around?