Code order?

MonkeyMan666 · January 14th, 2009, 04:15 AM

Hiya,

I have a chunk of code (see below) which on the click of a button makes a picture and label visible, then uploads a file then sends an email. It is uploading the file and sending the email before making the image visible. Do I need to refresh the page before doing anything with the file and email?

My code is:

Code:

string filename = fulUploader.FileName;
lblUploading.Visible = true;
imgRadio.Visible = true;
UploadFile(filename);
SendDownloadEmail();

The code for uploading the file and sending the email works fine, its just getting the image visible before doing anything else.

Thank you in advance

Andy

Lee Dumond · January 14th, 2009, 01:14 PM

Your code is firing in the correct order. The reason it appears as though it's not, is that you can't actually "see" that the image has been made visible until you get the response back from the post.

If you want it to work the other way around, you may want to consider controlling the visibility of the image and label from the client side using JavaScript.

PeterPeiGuo · January 14th, 2009, 08:45 PM

To improve user experience, it is better to have SendDownloadEmail() async - less response time.

PeterPeiGuo · January 14th, 2009, 08:48 PM

Not tested, but if you set visible to true in javascript, I think it will apear right the way...

MonkeyMan666 · January 15th, 2009, 06:21 AM

I have got the visibility working through javascript but how do I go about calling the web methods in C# from javascript.

Lee Dumond · January 15th, 2009, 01:30 PM

Quote:

Originally Posted by MonkeyMan666

I have got the visibility working through javascript but how do I go about calling the web methods in C# from javascript.

It depends on how critical it is for the events to all happen in a series.

I was thinking you could still do the server side uploading and email by wiring the click event as you have been, and triggering the script from OnClientClick in the same button. This would be the easiest way to go and would make it appear as though the label/image visibility was happening first, though in reality both the client and server functions would be called at the same time.

If that's not cutting the mustard for you, following is an interesting article about calling a server side method using JavaScript:

http://www.azamsharp.com/Posts/92_A_...rameworks.aspx

PeterPeiGuo · January 15th, 2009, 02:31 PM

Quote:

Originally Posted by Lee Dumond

I was thinking you could still do the server side uploading and email by wiring the click event as you have been, and triggering the script from OnClientClick in the same button.

I was thinking the same way. This actually matches the principle to separate view from data. His javascript mainly deals with view, for example set those to visible.