Form Validation w/ Cookies, Errors?

Spookster187 · September 4th, 2004, 09:05 AM

Hey all, nice community you got going. Just to introduce myself to be kind, I am Ryan Barr (Spooky) of Spoono.com and The owner of Blizter.net, and the owner, founder, and coder of BillAxis.

The issue I am having is based on BillAxis. It is (or will be) a Webhosting Client System (Billing, Invoices, Etc). I started to make it so I could have a whack at blowing PHPCoin out of the water from hate. So here it is: http://blizter.net/ba_lite/ . Yes, I understand, plain... the thing is, I need to get the login (if you click it, it appears), to work. After the login works, I will make the admin panel to control all of the content on the other pages.

Here is my code:

Code:

<?php

if ($submit_login) {
 include ("config.php");
 $Connect = mysql_connect ($MySQL_Host, $MySQL_User, $MySQL_Pass);
 mysql_select_db ($MySQL_DB);

 $Get_Action_UN = "SELECT * from UserList where Username='$Login[Username]' AND Password='$Login[Password]'";
 $Get_Query_UN = mysql_query($Get_Action_UN);
 $Get_Amount_UN = mysql_num_rows($Get_Query_UN);

 if ($Get_Amount_UN == '1') {
   setcookie ("C_User", $Login[Username]);
   setcookie ("C_Pass", "$Login[Password]");
   setcookie ("C_UserType", "$UserType");
   setcookie ("C_LoggedIn", "True");

   echo ("$Txt13d2");

   $Set_Cookies = "TRUE";

   if ($Set_Cookies == "TRUE") {
     echo ("The cookies are: $_COOKIE[C_User] $_COOKIE[C_Pass] $_COOKIE[UserType] $_COOKIE[LoggedIn]");
   }

 } elseif ($Get_Amount_UN == '0') {
   echo ("<b>$Txt10d2 $Login[Username] $Txt11d2</b>");
 }
 
 mysql_close ($Connect);
}

?>

What this is to do, is get information from the login form, process the Username and Password to see if they are correct from the database ( Guest // Guest ), then if they are, then it will create the cookies for one hour.

I understand I could use sessions, but I dont want to. Because this is the "Lite" version. And I want to put sessions in the "Pro" version :).

So, you can go to http://blizter.net/ba_lite/?id=login and put in Guest // Guest , and then see the error I am getting with the code.

Any help is greatly appreciated. :)

Ryan Barr
<('.'<) (>'.'<) (>'.')>

Moharo · September 10th, 2004, 05:27 AM

hey Spookster :D

first of all, you need to add some stuff for your code. if you want to specify the expiration time for a cookie you need to invoke the setcookie() function with more params...

bool setcookie ( string name [, string value [, int expire [, string path [, string domain [, bool secure]]]]])

that's how php.net has it... look at your code and go to the lines where you have setcookie() called 4 times, this is how i would do it:

global $HTTP_COOKIE_VARS;
$expire = time() + 3600; //expires within next hour

setcookie ("C_User", $Login[Username],$expire,"/","",0);
$HTTP_COOKIE_VARS["C_User"] = $Login[Username];

setcookie ("C_Pass", "$Login[Password]",$expire,"/","",0);
$HTTP_COOKIE_VARS["C_Pass"] = $Login[Password];

setcookie ("C_UserType", "$UserType",$expire,"/","",0);
$HTTP_COOKIE["C_UserType"] = $UserType;

setcookie ("C_LoggedIn", "True",$expire,"/","",0);
$HTTP_COOKIE["C_LoggedIn"] = "True";

make sure that you don't use $_COOKIE, it seems that there's no difference between $HTTP_COOKIE_VARS, but for some reason $_COOKIE is messy, and if you use $HTTP_COOKIE_VARS array make sure you call the header('location: whatever.php');

you have to declare that $HTTP_COOKIE_VARS is global like in the example above and you MUST call header() after all cookies are set....

hope that helped you

www.campusgrind.com the college portal

Snib · September 10th, 2004, 09:56 AM

Moharo,

HTTP_*_VARS IS A BAD THING. To see what I'm talking about, look at Nik's reply to this thread.

$_COOKIE is preferred to the depreciated HTTP vars.

BTW, how is $_COOKIE messy?

Snib

<><

Moharo · September 10th, 2004, 02:08 PM

Hey Snib

I'm writing about $_COOKIE as messy because some time ago I had some real problems with cookies when I used $_COOKIE, it (as usually) concerned IE 6. I read somewhere that IE6 uses something called P3P (Platform for Privacy Preferences) and it filters out third party cookies. It surely didn't work, cookies expired in no time. I know that $HTTP_COOKIE_VARS is old but it saved my day.... older doesn't mean it's bad :D

www.campusgrind.com the college portal