Is there an error in the Delete procedures for all of the items? I only get the Confirmation message when I click the delete button on the Products/Downloads/etc. pages in the Management folder. Here is the code I have in my installation on the Downloads page:

Protected Sub gvDownload_RowCommand(ByVal sender As Object, ByVal e As System.Web.UI.WebControls.GridViewCommandEventArgs ) Handles gvDownload.RowCommand

    Dim selectedIndex As Integer
    Dim productId As Integer

    Select Case e.CommandName.ToLower()
      Case "edititem"
        selectedIndex = Convert.ToInt32(e.CommandArgument)
        productId = Convert.ToInt32(gvDownload.DataKeys(selectedIndex) .Value)
        Response.Redirect(String.Format("InsertUpdateDownl oad.aspx?Id={0}", productId.ToString()))
      Case "deleteitem"
        selectedIndex = Convert.ToInt32(e.CommandArgument)
        productId = Convert.ToInt32(gvDownload.DataKeys(selectedIndex) .Value)
        Download.Delete(productId)
        gvDownload.DataBind()
    End Select
  End Sub

  Protected Sub gvDownload_RowCreated(ByVal sender As Object, ByVal e As System.Web.UI.WebControls.GridViewRowEventArgs) Handles gvDownload.RowCreated
    ' Find a reference to the Delete button and add a confirmation message
    If e.Row.RowType = DataControlRowType.DataRow Then
      Dim myButton As Button = CType(e.Row.Cells(3).Controls(0), Button)
      myButton.OnClientClick = "return confirm('Are you sure you want to delete this download?');"
    End If
  End Sub
End Class

Oh and if I just delete the second procedure that adds the confirmation message, eveything deletes correctly.

How does the HTML for the Delete buttons look like when you open in the page in your browser?


AFAIK, there shouldn't be a problem with this code; all it does is add a confirmation box to each button. It shouldn't prevent you from actually deleting the item (unless you click Cancel of course ;) )

Do you get the confirmation dialog at all?

Imar

I do get the confirmation dialog.

This is the HTML generated for that whole page:

Hi mfoof,

This is weird. I can't see anything wrong with this code. It should ask for confirmation and when you click OK, it should post back to the server and delete the item.

Do you have JavaScript enabled? Can you reproduce the problem on a different browser or machine?


Imar

JavaScript is enabled. I have reproduced it every time on two different machines, in IE 6.0 and Firefox 1.5, and Opera 9.0.

When I remove the sub to add the Confirmation Message, the deleteitem fires correctly.

I will take a closer look at how the "...OnClientClick = 'return confirm..." methods work. Really hope to figure this one out. Thanks.

Hi mfoof,

Sorry for the delay. took me a while to figure this one out.

Anyway, here's what happened:

By default, a ButtonColumn renders as an <input type="button"> HTML element. Normally, this is fine, as some JavaScript is embedded to submit the form when the button is clicked. However, with the delete confirmation code, things get messed up. Take a look at this:

<input type="button" value="Delete" onclick="return confirm('Are you
sure you want to delete this product?');javascript:__doPostBack
('ctl00$MainContentPlaceHolder$gvProduct','DeleteI tem$0')" />

When you click OK, you effectively have this:

onclick="return true";

This blocks the following JavaScript code from being executed and the form is never executed.

The fix is reasonably easy though.

1. Open the Products page in Design View

2. Open the Smart Task and choose Edit Columns

3. Locate the Delete column and convert it to a template by clicking the blue link.

You should end up with something like this:

<asp:TemplateField HeaderText="Delete" ShowHeader="False">
  <ItemStyle Width="75px" />
  <HeaderStyle HorizontalAlign="Left" />
  <ItemTemplate>
    <asp:Button ID="Button1" runat="server"
      CausesValidation="false" CommandName="DeleteItem" Text="Delete"
    />
  </ItemTemplate>
</asp:TemplateField>

4. Modify the code so you end up with this:

<asp:TemplateField HeaderText="Delete" ShowHeader="False">
  <ItemStyle Width="75px" />
  <HeaderStyle HorizontalAlign="Left" />
  <ItemTemplate>
    <asp:Button ID="Button1" CommandArgument='<%# Eval("Id") %>'
      runat="server" CausesValidation="false"
      CommandName="DeleteItem" Text="Delete"
      OnClientClick="return confirm('Are you sure you want to delete
          this product?');"           />
  </ItemTemplate>
</asp:TemplateField>

(I added the CommandArgument and the OnClientClick properties)

Because the command argument now contains the product ID, you need to change some code in the code behind as well.

5. Locate the gvProduct_RowCommand event handler and change the case for deleteitem to this:

      Case "deleteitem"
        productId = Convert.ToInt32(e.CommandArgument)
        Product.Delete(productId)
        gvProduct.DataBind()

6. Run the page. If everything worked out as planned (it's a million degrees out here so maybe due to the heat I left something out) you should now be able to delete products.

If not, please let me know.

Next time when you post code here, can you please add a few line breaks? The page I am typing this message in is a about 3 feet wide... ;)

Cheers,

Imar
---------------------------------------
Imar Spaanjaars
Everyone is unique, except for me.
Author of ASP.NET 2.0 Instant Results and Beginning Dreamweaver MX / MX 2004

This works.

If e.Row.RowType = DataControlRowType.DataRow Then
   Dim lb As LinkButton
   lb = e.Row.Cells(0).Controls(0)
   lb.Attributes.Add("onclick", "if(!confirm('Are you sure you want to delete this row?') return false;")
End If

You can use the field template as others have suggested but this is much more simple and will fire the correct event.

Still can't delete products in Customer Support

I've implemented your fix, but get following error:

  "Unable to cast object of type 'System.Web.UI.LiteralControl' to
   type 'System.Web.UI.WebControls.Button'."

Error occurs in this line of gvProduct_RowCreated Event:

  Dim myButton As Button = CType(e.Row.Cells(3).Controls(0), Button)

Products.aspx changes in Delete as follows:

      <asp:ButtonField ButtonType="Button" CommandName="EditItem" Text="Edit" HeaderText="Edit">
        <ItemStyle Width="75px" />
        <HeaderStyle HorizontalAlign="Left" />
      </asp:ButtonField>
      <asp:TemplateField HeaderText="Delete" ShowHeader="False">
        <ItemStyle Width="75px" />
        <HeaderStyle HorizontalAlign="Left" />
        <ItemTemplate>
        <asp:Button ID="Button1" CommandArgument='<%# Eval("Id") %>'
            runat="server" CausesValidation="false"
            CommandName="DeleteItem" Text="Delete"
            OnClientClick="return confirm('Are you sure you want to delete
        this product?');" />
        </ItemTemplate>
      </asp:TemplateField>
    </Columns>

Changes in code behind as follows:

Protected Sub gvProduct_RowCommand(ByVal sender As Object, ByVal e As System.Web.UI.WebControls.GridViewCommandEventArgs ) Handles gvProduct.RowCommand
    Dim selectedIndex As Integer
    Dim productId As Integer
    Select Case e.CommandName.ToLower()
      Case "edititem"
        selectedIndex = Convert.ToInt32(e.CommandArgument)
        productId = Convert.ToInt32(gvProduct.DataKeys(selectedIndex). Value)
        Response.Redirect(String.Format("InsertUpdateProdu ct.aspx?Id={0}", productId.ToString()))
      Case "deleteitem"
                productId = Convert.ToInt32(e.CommandArgument)
                Product.Delete(productId)
                gvProduct.DataBind()
                'selectedIndex = Convert.ToInt32(e.CommandArgument)
                ' productId = Convert.ToInt32(gvProduct.DataKeys(selectedIndex). Value)
                ' Product.Delete(productId)
                ' gvProduct.DataBind()
        End Select
  End Sub

Very much appreciate your help to get this working.

All the best

John