Fix: Chapter 7 - Earthquake IllegalStateException Finalizing cursor

juniper · August 16th, 2010, 04:35 PM

Hi,
The debugger was suspending the Ch. 7 Earthquake app due to an IllegalStateException. The error from LogCat:
Ljava/lang/IllegalStateException;: Finalizing cursor android.database.sqlite.SQLiteCursor@44c5db08 on earthquakes that has not been deactivated or closed

I traced the problem to this line in Earthquake.addNewQuake(...):

Code:

if (cr.query(EarthquakeProvider.CONTENT_URI, null, where, null, null).getCount() == 0) {

cr.query opens a new cursor, but it's not being properly closed.

Here is how I worked around the problem:

Code:

Cursor cursor = cr.query(EarthquakeProvider.CONTENT_URI, null, where, null, null);
int count = cursor.getCount();
cursor.close();
if (count == 0) {

MellowFellow · August 17th, 2010, 10:06 AM

I tried this fix, it reduced the occurrences of the error from 6 to 2 but does not seem to have fully eliminated the problem when I run it. Is there another instance in another activity where the cursor has to be closed?

This is the error I get 2 instances of:

ERROR/Cursor(431): Finalizing a Cursor that has not been deactivated or closed. database = /data/data/com.paad.earthquake/databases/earthquakes.db, table = earthquakes, query = SELECT * FROM earthquakes ORDER BY date
ERROR/Cursor(431):android.database.sqlite.DatabaseObject NotClosedException: Application did not close the cursor or database object that was opened here

juniper · August 17th, 2010, 12:53 PM

Hi MellowFellow,

Add c.close() as the last line of loadQuakesFromProvider():

Code:

	} while(c.moveToNext());
      }
      c.close();
    }

LostRobot · August 19th, 2011, 03:25 AM

Quote:

Originally Posted by juniper

Hi,
The debugger was suspending the Ch. 7 Earthquake app due to an IllegalStateException. The error from LogCat:
Ljava/lang/IllegalStateException;: Finalizing cursor android.database.sqlite.SQLiteCursor@44c5db08 on earthquakes that has not been deactivated or closed

I traced the problem to this line in Earthquake.addNewQuake(...):

Code:

if (cr.query(EarthquakeProvider.CONTENT_URI, null, where, null, null).getCount() == 0) {

cr.query opens a new cursor, but it's not being properly closed.

Here is how I worked around the problem:

Code:

Cursor cursor = cr.query(EarthquakeProvider.CONTENT_URI, null, where, null, null);
int count = cursor.getCount();
cursor.close();
if (count == 0) {

try this

Code:

  private void addNewQuake(Quake _quake) {
    ContentResolver cr = getContentResolver();
    // Construct a where clause to make sure we donÃt already have this 
    // earthquake in the provider.
    String w = EarthquakeProvider.KEY_DATE + " = " + _quake.getDate().getTime();

    // If the earthquake is new, insert it into the provider.
    Cursor c = cr.query(EarthquakeProvider.CONTENT_URI, null, w, null, null);
    if (c.getCount()==0){
      ContentValues values = new ContentValues();    

      values.put(EarthquakeProvider.KEY_DATE, _quake.getDate().getTime());
      values.put(EarthquakeProvider.KEY_DETAILS, _quake.getDetails());

      double lat = _quake.getLocation().getLatitude();
      double lng = _quake.getLocation().getLongitude();
      values.put(EarthquakeProvider.KEY_LOCATION_LAT, lat);
      values.put(EarthquakeProvider.KEY_LOCATION_LNG, lng);
      values.put(EarthquakeProvider.KEY_LINK, _quake.getLink());
      values.put(EarthquakeProvider.KEY_MAGNITUDE, _quake.getMagnitude());

      cr.insert(EarthquakeProvider.CONTENT_URI, values);
      announceNewQuake(_quake);
    }
    c.close();
  }