Chap 6 Earthquake new thread problem

[xcopy]

In the Ch6 Earthquake program there's a problem with initiating an internet access from a fragment (EarthquakeListFragment.java)

Specifically, the author says that due to API changes and best practices instead of using a direct call to the xml retrieve/parse routine as in:

public void onActivityCreated(Bundle savedInstanceState) {
		super.onActivityCreated(savedInstanceState);

		int layoutID = android.R.layout.simple_list_item_1;
		aa = new ArrayAdapter<Quake>(getActivity(), layoutID , earthquakes);
		setListAdapter(aa);

refreshEarthquakes();

You should replace the single line of refreshEarthquakes() with the following. It should open a new thread to call the routine and keep the processing off the main thread:

Thread t = new Thread(new Runnable() {
			public void run() {
				refreshEarthquakes();
			}
		});
		
		t.start();

The problem is twofold.

1) The new thread code he offered doesn't seem to work correctly.

2) If i remove the <uses-sdk ...../> clause from the manifest file the original version (#1 above) works, but including the clause with either version causes the application to crash.

Is there a quick solution that anyone has found to get this to work, or must it use some type of Async Task or service?

thanks

[uler3161]

What do you mean by "doesn't seem to work correctly."? Is there an exception being thrown?

[xcopy]

Apologize for my noobness and sorry if i didn't provide all information.

The array adapter didn't like being modified by this thread because I omitted the handler/runnable wrapper. Once I figured out my complete brain fade and saw that it was missing, the app runs as it should.

	handler.post(new Runnable() {
			public void run() {
			    addNewQuake(quake);
			}
		});

Still, I find it strange that the manifestation of this problem was in the manifest file. Why the uses-sdk clause caused the app to fail, or run when it was removed, is odd. To me anyway..

[chod]

Hi xcopy,

I am a noob and am having the same problem. Can you please explain in more details how you solve the problem? Thanks in advance.

[chod]

After scratching my head, I realised the error. The code is provided is not correct and please follow the code in the book for EarthquakeListFragment.java.

[xcopy]

Originally Posted by chod

After scratching my head, I realised the error. The code is provided is not correct and please follow the code in the book for EarthquakeListFragment.java.

Exactly. I guess it should show up on an errata or something, but the book is correct and the downloaded code is wrong.

[Kees]

A possible "quick" solution i posted to the problem that newbie had (no earthquake listing was generated).
I found it in my environment due to exception : "android.view.ViewRoot$CalledFromWrongThreadExcept ion: Only the original thread that created a view hierarchy can touch its views"
when aa.notifyDataSetChanged() is called.

Hope this can help..