text game

132591 · #1 (**permalink**) October 27th, 2006, 06:17 PM

what is wrong with this code?

class.h:

Code:

#include <iostream>
#include <stdlib.h>

using namespace std;


class thisroom{
        public:
            string description; //description of the room

            string act;
            int action; //variable that determines whether an action can take place in the room    

            //room pointers
            thisroom *north;
            thisroom *south;
            thisroom *east;
            thisroom *west;

            void actiondesc();

};

main.cpp:

Code:

#include <iostream>
#include <stdlib.h>
//room class
#include "class.h" 

using namespace std;


int main(int argc, const char *argv[]){
    string direction;
    int i;


    thisroom dungeon[6];

    thisroom *saveroom;
    thisroom *curroom;

    //sets descriptions
    dungeon[0].description = "center room";
    dungeon[1].description = "north room";
    dungeon[2].description = "west room";
    dungeon[3].description = "south room";
    dungeon[4].description = "east room";
    dungeon[5].description = "really north room";


    //sets default pointers to NULL
    for(i = 0; i < 6; i++){
        dungeon[i].east = NULL;
        dungeon[i].west = NULL;
        dungeon[i].north = NULL;
        dungeon[i].south = NULL;
    }

    //sets correct pointer values
    dungeon[0].north = &dungeon[1];
    dungeon[0].west = &dungeon[2];
    dungeon[0].south = &dungeon[3];
    dungeon[0].east = &dungeon[4];

    dungeon[1].south = &dungeon[0];
    dungeon[1].north = &dungeon[5];

    dungeon[2].east = &dungeon[0];

    dungeon[3].north = &dungeon[0];

    dungeon[4].west = &dungeon[0];

    dungeon[5].south = &dungeon[1];


    //sets action capabilities
    for(i = 0; i < 6; i++){
        dungeon[i].action = NULL;
    }
    dungeon[5].action = 1;

    dungeon[5].act = "sniff";
    dungeon[5].actiondesc(){
        cout <<"You sniff the fould air" <<endl;
    }

    curroom = &dungeon[0];

    while(direction != "bye"){
        cout << curroom->description <<endl; //echoes the room description
        cin >>direction; //gets direction

        saveroom = curroom; //in case we need to call the room again

        if(curroom->action == 1){
            if(direction == curroom->act){
                curroom->actiondesc();
            }
            else{
                cout <<"You cannot doeth that." <<endl;
            }
        }

        if(direction == "west"){
            curroom = curroom->west;
        }
        else if(direction == "north"){
            curroom = curroom->north;
        }
        else if(direction == "east"){
            curroom = curroom->east;
        }
        else if(direction == "south"){
            curroom = curroom->south;
        }
        if(curroom == NULL){
            cout <<"You cannot goeth that way." <<endl;
            curroom = saveroom; //sets curoom to the room you were last in
        }
    }

    return 0;
}

"Judge a man by his questions, not by his answers."
-Voltaire
\

Geo121 · #2 (**permalink**) October 30th, 2006, 08:57 AM

Wow . . .

I am really impressed with this idea.

I never thought of having a map like scenario like this.

If you don't mind I think I might use it sometime.

Anyways I found your problem it's very small but it is serious

okay are you ready?

the function actiondesc() in your class thisroom is a good idea except because it is a class you can't declare multiple abstract functions for the values of the dungeon array

UNDERSTAND??

you had

dungeon[5].actiondesc(){
cout <<"You sniff the fould air" <<endl;
}

now there are two problems with these lines of code

first you are trying to declare a function inside of a function that is just bad programming practice

second you can't create seperately declared functions for each value of the array

instead you should declare the function outside of the main function and it should be similar if not exactly like this

~ Geo

Geo121 · #3 (**permalink**) October 30th, 2006, 08:58 AM

void thisroom::actiondesc(string act)
{
     if (act == "sniff")
     {
          cout << "You sniff the fould air" << endl;
     }
}

~ Geo

Geo121 · #4 (**permalink**) October 30th, 2006, 08:59 AM

and then change your function declaration inside of your class to

void actiondesc(string);

~ Geo

Geo121 · #5 (**permalink**) October 30th, 2006, 09:00 AM

after a few changes your overall code should look like this :

#include <iostream>
#include <stdlib.h>

using namespace std;

class thisroom{
        public:
            string description; //description of the room

            string act;
            int action; //variable that determines whether an action can take place in the room

            //room pointers
            thisroom *north;
            thisroom *south;
            thisroom *east;
            thisroom *west;

            void actiondesc(string);

};

int main(int argc, const char *argv[]){
    string direction;
    int i;

    thisroom dungeon[6];

    thisroom *saveroom;
    thisroom *curroom;

    //sets descriptions
    dungeon[0].description = "center room";
    dungeon[1].description = "north room";
    dungeon[2].description = "west room";
    dungeon[3].description = "south room";
    dungeon[4].description = "east room";
    dungeon[5].description = "really north room";

    //sets default pointers to NULL
    for(i = 0; i < 6; i++){
        dungeon[i].east = NULL;
        dungeon[i].west = NULL;
        dungeon[i].north = NULL;
        dungeon[i].south = NULL;
    }

    //sets correct pointer values
    dungeon[0].north = &dungeon[1];
    dungeon[0].west = &dungeon[2];
    dungeon[0].south = &dungeon[3];
    dungeon[0].east = &dungeon[4];

    dungeon[1].south = &dungeon[0];
    dungeon[1].north = &dungeon[5];

    dungeon[2].east = &dungeon[0];

    dungeon[3].north = &dungeon[0];

    dungeon[4].west = &dungeon[0];

    dungeon[5].south = &dungeon[1];

    //sets action capabilities
    for(i = 0; i < 6; i++){
        dungeon[i].action = NULL;
    }
    dungeon[5].action = 1;

    dungeon[5].act = "sniff";

    curroom = &dungeon[0];

    while(direction != "bye"){
        cout << curroom->description <<endl; //echoes the room description
        cin >>direction; //gets direction

        saveroom = curroom; //in case we need to call the room again

        if(curroom->action == 1){
            if(direction == curroom->act){
                curroom->actiondesc(curroom->act);
            }
            else{
                cout <<"You cannot doeth that." <<endl;
            }
        }

        if(direction == "west"){
            curroom = curroom->west;
        }
        else if(direction == "north"){
            curroom = curroom->north;
        }
        else if(direction == "east"){
            curroom = curroom->east;
        }
        else if(direction == "south"){
            curroom = curroom->south;
        }
        if(curroom == NULL){
            cout <<"You cannot goeth that way." <<endl;
            curroom = saveroom; //sets curoom to the room you were last in
        }
    }

    return 0;
}

void thisroom::actiondesc(string act)
{
     if (act == "sniff")
     {
          cout << "You sniff the fould air" << endl;
     }
}

~ Geo

Geo121 · #6 (**permalink**) October 30th, 2006, 09:02 AM

Don't worry about the compiler warning if you get one because thats just telling you that NULL isn't an int

~ Geo

Geo121 · #7 (**permalink**) October 30th, 2006, 09:05 AM

I am very impressed with this idea

I would like for you to inform of this games completion and see if you could send me the executable or the source and I will compile it

I am also warmed inside by your wanting to use polymorphic ideas

especially after this post some guy with a masters in computer science stated that he didn't undertand polymorphism.

I was very upset after that seeeing how I'm only 17 and haven't even been to college and he has his masters

but you brightened my day and I posted a link to this post for him so he could see how you were doing

=P

~ Geo

Geo121 · #8 (**permalink**) October 30th, 2006, 09:09 AM

P.S.

I just thought of this . . .

A good idea for this map like system would be to create a two dimensional array apply letter / number mapping coordinates to it and then have attributes like weather and surroundings and walkable/flyable/swimmable and stuff to create an extremely detailed and interactive text based enviroment

I really wanna see it when you are done

=P

~ Geo

132591 · #9 (**permalink**) November 17th, 2006, 10:00 PM

I will definitely get working on that game. If you want to email me, click http://www.redeyegamez.com/contactus.html

"Judge a man by his questions, not by his answers."
-Voltaire
\

132591 · #10 (**permalink**) November 18th, 2006, 03:02 PM

Also I need help with something else. How would I keep track of a person's points and kills? I cannot simly do this

Code:

class thisroom{
    public:
        int killcount
};
void thisroom::actionsdesc(string act){
    if(act=="kill monster"){
        killcount++;
    }
}
cout <<thisroom::killcount <<endl;

also, how do I set actions that can only take place a fixed amount of times?

"Judge a man by his questions, not by his answers."
-Voltaire
\