I'm trying to do an if test to disply a message if a record value in a db is less than 3, but it displays the message always, see code below. Also I'm looking for some sample code of a comboBox control in C#, I want to populate the combox using a stored procedure, any examples appreciated.

SqlDataAdapter da = new SqlDataAdapter
    ("SELECT MAX(FeedbackId) as FeedbackId, ComfortLevel from Feedbacks GROUP BY FeedbackId, ComfortLevel", StrConnection);
    DataSet ds = new DataSet();
     da.Fill(ds,"Feedbacks");

     foreach (DataRow dr in ds.Tables["Feedbacks"].Rows)

     {
         int id = (int)dr["ComfortLevel"];
         if (id == 3)
            {
                 message2.Text = "Contact a tutor";
            }

     }

The use of a loop there doesn't entirely make sense.

The message could get set on one row, but then following rows may not hit the if. So the logic isn't really logical.

-Peter

But the SQL should bring back the last record in the table, therefore there will only be one row inside the loop?

Sorry the oroginal code did not include my less than test

SqlDataAdapter da = new SqlDataAdapter
    ("SELECT MAX(FeedbackId) as FeedbackId, ComfortLevel from Feedbacks GROUP BY FeedbackId, ComfortLevel", StrConnection);
    DataSet ds = new DataSet();
     da.Fill(ds,"Feedbacks");

      foreach (DataRow dr in ds.Tables["Feedbacks"].Rows)

      {
          int id = (int)dr["ComfortLevel"];
           if (id < 3)
            {
                 message2.Text = "Contact a tutor";
            }

      }

Whats the best way of getting the value from a column inside a table row? Avoid using a foreach loop? In classic ASP I would just do the following:

Create a recordset with the sql above then:

<% If RS_Message("ComfortLevel") < 3 Then Response.Write("Contact a tutor") %>

Sorry Peter you was correct, my sql was bringing back more than one row, I'm slightly embarrassed, here is the code working correctly:

 SqlDataAdapter da = new SqlDataAdapter
    ("SELECT * FROM dbo.Feedbacks WHERE (FeedbackId = (SELECT MAX(FeedbackID) FROM Feedbacks))", StrConnection);
    DataSet ds = new DataSet();
     da.Fill(ds,"Feedbacks");

      foreach (DataRow dr in ds.Tables["Feedbacks"].Rows)

      {
          int id = (int)dr["ComfortLevel"];
           if (id < 3)
            {
                          message2.Text = "Contact a tutor";
            }

      }

Using the dataset, if you know that you'll only get one row, you can just access the row directly:

  int id = (int)ds.Table["Feedbacks"].Rows[0]["ComfortLevel"];


If you are doing a data aggregation and are looking for only a single value you could further simplify your code to something like this:

  SqlCommand objCmd = new SqlCommand("SELECT * FROM dbo.Feedbacks WHERE (FeedbackId = (SELECT MAX(FeedbackID) FROM Feedbacks))", new SqlConnection(StrConnection));
  objCmd.Connection.Open();
  int id = (int)objCmd.ExecuteScalar();
  objCmd.Connection.Close();
  if (id < 3)
  {
    message2.Text = "Contact a tutor";
  }

http://msdn.microsoft.com/library/en...calartopic.asp

-Peter

Thanks Peter