make javascript code more dynamic

crmpicco · September 27th, 2005, 06:28 AM

Code:

        noinf = document.form.noi.value;

        if(noinf==2)
        {
            var inf_length2 = document.form.birthday2.value.length

            if((Math.ceil(inf_length2)<8)&&(Math.ceil(inf_length2)!=0))
            {
                var do_not_check_full_dob = true;
            }
            if(Math.ceil(inf_length2)==8)
            {
                var do_not_check_full_dob = false;
            }

        }

        if(noinf==3)
        {
            var inf_length3 = document.form.birthday3.value.length

            if((Math.ceil(inf_length3)<8)&&(Math.ceil(inf_length3)!=0))
            {
                var do_not_check_full_dob = true;
            }
            if(Math.ceil(inf_length3)==8)
            {
                var do_not_check_full_dob = false;
            }

        }

        if(noinf==4)
        {
            var inf_length4 = document.form.birthday4.value.length

            if((Math.ceil(inf_length4)<8)&&(Math.ceil(inf_length4)!=0))
            {
                var do_not_check_full_dob = true;
            }
            if(Math.ceil(inf_length4)==8)
            {
                var do_not_check_full_dob = false;
            }

        }

I am trying to make my code run as smoothly as possible, is there a way to make this code more dynamic? Put it in a loop or something?

Picco

www.crmpicco.co.uk
www.crmpicco.co.uk.tt
www.milklemonadechocolate.uk.tt
www.griswolds.uk.tt
www.piccosmini.co.uk.tt
www.morton.uk.tt

g2000 · September 27th, 2005, 11:44 AM

Based upon what you wrote, I think you meant to check the dob.
1st: I would use switch
2nd: Write up a function to get the value length
3rd: Conditional operator

function yourFunc(){
noinf = document.form.noi.value;

if noinf != "" {
  var inf_length = getValueLength('birthday'+ noinf);
  do_not_check_full_dob = (inf_length > 0) ?
       ( (inf_length < 8)? true: false) : false;

} // if noinf != ""

.... your other operations...

} // end yourFunc()

}

/** get the length */
function getValueLength(controlID){
  if (document.form.controlID) {
    return document.form.controlID.value.length;
  }
}