make javascript code more dynamic

crmpicco · October 14th, 2005, 10:08 AM

Code:

else if (segments == 6)
                        {
                            if ((document.forms["form"].elements["ad1"].value == "") && (document.forms["form"].elements["ad2"].value != "") && (document.forms["form"].elements["ad3"].value != "") && (document.forms["form"].elements["ad4"].value != "") && (document.forms["form"].elements["ad5"].value != "") && (document.forms["form"].elements["ad6"].value == ""))
                            {
                                el.innerHTML = el.innerHTML + seatArr[s-2];
                            }
                            if ((document.forms["form"].elements["ad1"].value == "") && (document.forms["form"].elements["ad2"].value == "") && (document.forms["form"].elements["ad3"].value == "") && (document.forms["form"].elements["ad4"].value == "") && (document.forms["form"].elements["ad5"].value != "") && (document.forms["form"].elements["ad6"].value == ""))
                            {
                                el.innerHTML = el.innerHTML + seatArr[s-5];
                            }
                            if ((document.forms["form"].elements["ad1"].value == "") && (document.forms["form"].elements["ad2"].value == "") && (document.forms["form"].elements["ad3"].value == "") && (document.forms["form"].elements["ad4"].value != "") && (document.forms["form"].elements["ad5"].value == "") && (document.forms["form"].elements["ad6"].value == ""))
                            {
                                el.innerHTML = el.innerHTML + seatArr[s-4];
                            }
                            if ((document.forms["form"].elements["ad1"].value == "") && (document.forms["form"].elements["ad2"].value != "") && (document.forms["form"].elements["ad3"].value == "") && (document.forms["form"].elements["ad4"].value == "") && (document.forms["form"].elements["ad5"].value == "") && (document.forms["form"].elements["ad6"].value == ""))
                            {
                                el.innerHTML = el.innerHTML + seatArr[s-2];
                            }
                            if ((document.forms["form"].elements["ad1"].value == "") && (document.forms["form"].elements["ad2"].value == "") && (document.forms["form"].elements["ad3"].value != "") && (document.forms["form"].elements["ad4"].value == "") && (document.forms["form"].elements["ad5"].value == "") && (document.forms["form"].elements["ad6"].value == ""))
                            {
                                el.innerHTML = el.innerHTML + seatArr[s-3];
                            }
                            if ((document.forms["form"].elements["ad1"].value == "") && (document.forms["form"].elements["ad2"].value == "") && (document.forms["form"].elements["ad3"].value == "") && (document.forms["form"].elements["ad4"].value == "") && (document.forms["form"].elements["ad5"].value == "") && (document.forms["form"].elements["ad6"].value != ""))
                            {
                                el.innerHTML = el.innerHTML + seatArr[s-6];
                            }
                            if ((document.forms["form"].elements["ad1"].value == "") && (document.forms["form"].elements["ad2"].value != "") && (document.forms["form"].elements["ad3"].value == "") && (document.forms["form"].elements["ad4"].value != "") && (document.forms["form"].elements["ad5"].value == "") && (document.forms["form"].elements["ad6"].value != ""))
                            {
                                el.innerHTML = el.innerHTML + seatArr[s-2];
                            }

I have written this JavaScript code which is just one condition in the function. Can anyone see a way of making it more dynamic and cutting down the code?

I cant see it,

:-(

Picco

www.crmpicco.co.uk

interrupt · October 14th, 2005, 11:17 AM

You could shorten this line:

el.innerHTML = el.innerHTML + seatArr[s-2];

to:

e1.innerHTML+= seatArr[s-2];

Not sure about the rest, looks quite long winded though.

Joe

ChrisScott · October 14th, 2005, 12:31 PM

Hi Picco,

Try this...

Code:

// create array of empty field state
var f = document.forms["form"];
var adEmpty = new Array(6);
for(var i = 0; i < adEmpty.length; i++){
    adEmpty[i] = f.elements["ad" + (i + 1)].value == "";
}

// create array of conditions and text to append if true
var conditions = new Array(7);
conditions[0] = ["2345", seatArr[s-2]];
conditions[1] = ["5", seatArr[s-5]];
conditions[2] = ["4", seatArr[s-4]];
conditions[3] = ["2", seatArr[s-2]];
conditions[4] = ["3", seatArr[s-3]];
conditions[5] = ["6", seatArr[s-6]];
conditions[6] = ["246", seatArr[s-2]];

for(var i = 0; i < conditions.length; i++){
    var add = true;
    for(var j = 0; j < adEmpty.length; j++){
        // compare condition to state
        if((conditions[i][0].indexOf((j + 1).toString()) == -1) != adEmpty[j]){
            add = false;
            break;
        }
    }
    if(add){
        el.innerHTML += conditions[i][1];
    }
}

HTH,

Chris

crmpicco · October 17th, 2005, 05:40 AM

Thanks Chris, that code looks interesting. I'll bring that into my code.
Thanks Joe, added your code as well. Cheers:

Code:

el.innerHTML += seatArr[s-parseFloat(control)]

www.crmpicco.co.uk