battling to add username & password too similar...

Greywacke · October 7th, 2003, 11:10 AM

hi all,

i'm sitting with a huge problem which has been bugging me for the past week.
the outside if below always returns true even if in reality it is false o_O

Code:

// Start script section

if (username.substring(0,4).toUpperCase == password[0].substring(0,4).toUpperCase) {
    if (!confirm('Username and password are too similar.\nThis is not advised... Continue?')) {
        return false;
    }
}

// End script section

any swift help would be greatly appreciated,

Sincerely,
Pierre du Toit.

joefawcett · October 7th, 2003, 11:26 AM

Because there are no parentheses at the end of your expressions you are comparing functions not their results, try:

Code:

username.substring(0,4).toUpperCase() == password[0].substring(0,4).toUpperCase()

--

Joe

Greywacke · October 7th, 2003, 12:07 PM

well, gonna test that now... but i always thought toUpperCase was a string property, not a function... thx for the help tho

Sincerely,
Pierre du Toit.

Greywacke · October 7th, 2003, 12:11 PM

yep it worked ;) thx a mill man...

Sincerely,
Pierre du Toit.

joefawcett · October 8th, 2003, 02:23 AM

If you'd followed one of the first rules of debugging, check your data, and alerted one of the values you'd have spotted it right away, compare:

Code:

alert(username.substring(0,4).toUpperCase);

to

Code:

alert(username.substring(0,4).toUpperCase());

--

Joe