Change css display value with JS

lcsgeek · January 23rd, 2009, 04:22 PM

Is there a limitation on non-IE browsers with the following?

Code:

 if(busLocationTypeValue == "n")
 {
  document.getElementById("divNonCentralLocation").style.display = 'block';
  document.getElementById("divCentralLocation").style.display = 'none';
  document.getElementById("cBusLocation").value = '';
 }
 else {
  document.getElementById("divNonCentralLocation").style.display = 'none';
  document.getElementById("divCentralLocation").style.display = 'block';
  document.getElementById("ncBusLocation").value = '';
 }

based on busLocationTypeValue I'm hiding or displaying one div or another. This code works in IE but nothing else.

thanks

Darin

lcsgeek · January 23rd, 2009, 04:28 PM

Sorry to bother. Reversing two lines makes it work now.

Code:

if(busLocationTypeValue == "n")
 {
  document.getElementById("divNonCentralLocation").style.display = 'block';
  document.getElementById("divCentralLocation").style.display = 'none';
  document.getElementById("cBusLocation").value = '';
 }
 else {
  document.getElementById("divCentralLocation").style.display = 'block';
  document.getElementById("divNonCentralLocation").style.display = 'none';
  document.getElementById("ncBusLocation").value = '';
 }

Old Pedant · January 23rd, 2009, 04:31 PM

Nope, I do this all the time.

Have you debugged??

Have you checked that busLocationTypeValue really *IS* only and exactly n in those other browsers?

&&&&&&&&&&&&&&&&&&&&&

Incidentally, you can write that more compactly:

Code:

 var isN = (busLocationTypeValue == "n");
 document.getElementById("divNonCentralLocation").style.display = isN ? 'block' : 'none';
 document.getElementById("divCentralLocation").style.display = isN ? 'none' : 'block'
 document.getElementById( (isN ? "c" : "nc" ) + "BusLocation").value = '';

Old Pedant · January 23rd, 2009, 04:33 PM

Quote:

Originally Posted by lcsgeek

Sorry to bother. Reversing two lines makes it work now.

WEIRD! Can't see why that would matter. Unless the two divs (or whatever they are) are somehow nested???