Why Doesn't This Work in IE?

wiswif · August 17th, 2011, 10:34 PM

Hi all,
Just wondering if anyone had any thoughts as to why this is working in IE (but works in Firefox)...

Code:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">

...

<script type="text/javascript">
function specificBoxVisible() {
	specBox = document.getElementById("specificBox");
	homeRadio = document.getElementsByName("home");
	var elementIndex;
	for (elementIndex in homeRadio) {
		if (homeRadio[elementIndex].checked) {
			if (homeRadio[elementIndex].value == "home") {
				specBox.className = "displayOff";

			} else {
			specBox.className = "displayOn";
			}
		}
	}
}
</script>

...

Specify a basic location: <input type='radio' name='home' value='home' onclick="specificBoxVisible()">Home <input type='radio' name='home' value='away' onclick="specificBoxVisible()">Out <input type='radio' name='home' value='either' onclick="specificBoxVisible()" checked='yes'>Either<br>

...as far as I know, there's nothing in there that should cause problems for IE, but it is VERY possible that I could be mistaken. Any help would be appreciated.

Thanks,
wiswif

joefawcett · August 18th, 2011, 04:26 AM

What exactly doesn't work? Does the code not find the checked element etc. or does changing the className have no effect on the display of the element?

As an aside the code seems a little complicated. Couldn't you just pass an argument to the function and avoid the loping entirely?

wiswif · August 20th, 2011, 12:30 PM

...duly noted.

Was something like this what you had in mind?

Code:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">

...

<script type="text/javascript">
function specificBoxVisible(value) {
	specBox = document.getElementById("specificBox");
	if (value == "home") {
		specBox.className = "displayOff";
	} else {
		specBox.className = "displayOn";
	}
}
</script>

...

Specify a basic location: <input type='radio' name='home' value='home' onclick="specificBoxVisible('home')">Home <input type='radio' name='home' value='away' onclick="specificBoxVisible('away')">Out <input type='radio' name='home' value='either' onclick="specificBoxVisible('either')" checked='yes'>Either<br>

...tried that in both browsers and it works swimmingly. I guess for some reason when I wrote the initial version I was attracted to the idea of javascript getting the values automatically, and the previous, contrived solution was the only way I could figure to do it. (I'm sure there's a simpler way, but like I said, I couldn't find it.)

Such is one of my big problems in coding... often, I'll take a somewhat unusual route to accomplish what I desire when I can't seem to figure a quicker one that I know probably exists... I wish there were a "Code Critique" forum where people could suggest better techniques, as most of my code, though functional, would probably make more experienced programmers scratch their heads. (Is there such a forum?)

Thanks kindly,
wiswif

joefawcett · September 2nd, 2011, 10:35 AM

Yes (sorry for late reply, was on holiday).