Help with function...

mathe · December 16th, 2003, 11:47 PM

Hey Guys, I need help with the function...if any of you already run the Namllu Holiday Booking Form (From Beginning PHP) -->holiday.html and work with the function on chapter 6 page 199 please help me...b/c my function does not work properly. Every time I run the program it only shows the default "Go back and do it again" without calculating the function itself.

Thank you for your help!!

nikolai · December 17th, 2003, 04:42 PM

Many of us don't have the book, nor do we have the source code downloaded. It'd be easiest for me to help you if you paste the relevant code and describe the application a little more.

I have some questions for you to answer, too -- have you been able to successfully run other scripts from the book, or is this your first attempt? What are the values of the register_globals and error_reporting PHP configuration directives? (you can check these values by running a phpinfo() script, and you can set them in php.ini).

Take care,

Nik
http://www.bigaction.org/

mathe · December 18th, 2003, 01:02 AM

Hi Nik, thx for the reply. Here is the code

HTML

<html>
<head></head>
<body>
<b>Namllu Holiday Booking Form</b>
<Form Method=Get Action="holiday3.php">
Where do you want to go on holiday?
<br>
<br>
<input name="Destination" type="Radio" value="Praque">
Praque
<br>
<input name="Destination" type="Radio" value="Barcelona">
Barcelona
<br>
<input name="Destination" type="Radio" value="Vienna">
Vienna
<br>
<br>
What grade of hotel do you want to stay at?
<br>
<br>
<input name="Grade" type="Radio" value="Three">
Three Star
<br>
<input name="Grade" type="Radio" value="Four">
Four Star
<br>
<br>
<input type=submit>
</form>
</body>
</html>

holiday3.php codes...

<html>
<head></head>
<body>
<?php
function Calculator($Price, $CityModifier, $StarModifier)
{
return $Price=$Price*$CityModifier*Starmodifier;
}
$Price=500;
$StarModifier=1;
$CityModifier=1;
$DestGrade=$Destination.$Grade;
switch($DestGrade){
  case "BarcelonaThree":
  $CityModifier=2;
  break;
  case "BarcelonaFour":
  $CityModifier=2;
  $StarModifier=2;
  break;
  case "ViennaThree":
  $CityModifier=3.5;
  break;
  case "ViennaFour":
  $CityModifier=3.5;
  $StarModifier=2;
  break;
  case "PraqueThree":
  break;
  case "PraqueFour":
  $StarModifier=2;
  break;
  default:
  $CityModifier=0;
  echo ("Go back and do it again");
}
if ($CityModifier<>0)
{
echo "The cost for a week in $Destination is "."$".
Calculator($Price,$CityModifier,$StarModifier);
}
?>
</body>
</html>

Thx Nik. I've checked my register_global=on and I've done a couple of scripts earlier. Everything works fine until this one came...

Thanks once again!

nikolai · December 18th, 2003, 04:00 PM

Two problems exist in holiday3.php. Here's your code:

Quote:

quote:
function Calculator($Price, $CityModifier, $StarModifier)
{
return $Price=$Price*$CityModifier*Starmodifier;
}

Both problems are on the same line. The first is that you don't have a dollar sign in front of "Starmodifier" in your return statement, so PHP thinks that you're looking up a defined constant. Since Starmodifier is NOT a named constant, PHP treats it as a string. PHP tries to convert that string to a number because you're using it in a mathematical expression (multiplication). Since the string "Starmodifier" doesn't contain any digits, it gets converted to zero. That's why all your prices are zero.

Second, your variable name is "StarModifier". PHP variable names are case-sensitive, so $StarModifier is __NOT__ the same thing as $Starmodifier.

Here's the fixed code:

function Calculator($Price, $CityModifier, $StarModifier)
{
return $Price * $CityModifier * $StarModifier;
}

Take care,

Nik
http://www.bigaction.org/