It said

Exception occurred

but the email's were still sent to my test address so I am not sure why that is

-----------------------------------------------------------
"Don't follow someone who's not going anywhere" John Mason

Nothing else? No error number?

What happens when you write out the SQL statement? I assume your code looks different from what you posted last time??

update "ORNewsletterTest set Mailsent=1 where NewsletterId In (" & NewsletterId & ")"

This won't work, as this isn't valid string or sql statement. Try fixing it, like this for example:

Dim SQL
SQL = "UPDATE ORNewsletterTest SET Mailsent=1 WHERE NewsletterId IN (" & NewsletterId & ")"
Response.Write(SQL)
Response.End

If you put that code in, what do you get?

Imar

---------------------------------------
Imar Spaanjaars
Everyone is unique, except for me.

Here is my new code with your new update statment

It stops on this line

error '80020009'
Exception occurred.

NewsletterId = NewsletterId & RS("NewsletterId")

-----------------------------------------------------------
"Don't follow someone who's not going anywhere" John Mason

What I meant was for you to post the outcome of your SQL statement. I think it will end up like this:

WHERE Bla bla IN (1, 2, 3, )

As you can see, it ends with an additional comma, which is not allowed. You'll need to strip it off before you send it to the database.

Cheers,

Imar
---------------------------------------
Imar Spaanjaars
Everyone is unique, except for me.

Oh, and another thing: You should move the code that adds the ID to inside the loop:

  RS.MoveNext
next
.....

     'And store the mailId or KeyFieldValue in an array

    If len(NewsletterId) > 0 Then
        NewsletterId = NewsletterId & ", "
    end if
    NewsletterId = NewsletterId & RS("NewsletterId")

As you can see, you loop through your entire recordset. After the last record, you try to access the recordset, which is not going to work as it is now EOF.

Imar
---------------------------------------
Imar Spaanjaars
Everyone is unique, except for me.

I can't show you the outcome of the sql statment because it never makes it there I moved this up into the loop but it still generates an error
I don't think the syntax is right :-(


If len(NewsletterId) > 0 Then
    NewsletterId = NewsletterId & ", "
    end if
 NewsletterId = NewsletterId & RS("NewsletterId")



-----------------------------------------------------------
"Don't follow someone who's not going anywhere" John Mason

Did you move it to before the MoveNext call?

well I did now ;)

Okay this time I got this

Update ORNewsletterTest set Mailsent=1 where NewsletterId in (, 1, 2, 3, 4, 5)



-----------------------------------------------------------
"Don't follow someone who's not going anywhere" John Mason

Right, that's what I thought. You need a way to ignore the first comma. There are at least 2 ways to do that.

1. Strip if of, right before you send it.

NewsletterId = Right(NewsletterId, (Len(NewsletterId) -2))

2. Alternatovely, don't add it in the first place. Inside your main loop, add a counter that keeps track of the number of records. If it's zero (the first record), don't add the comma:

If Len(NewsletterId) > 0 And LoopCounter > 0 Then
  NewsletterId = NewsletterId & ", "
End If


Cheers,

Imar
---------------------------------------
Imar Spaanjaars
Everyone is unique, except for me.

I added the loop like this

    If Len("NewsletterId") > 0 And LoopCounter > 0 Then
          NewsletterId = NewsletterId & ", "
    End If
    NewsletterId = NewsletterId & RS("NewsletterId")

But now it returns this vaule

Update ORNewsletterTest set Mailsent=1 where NewsletterId in (12345)

[EDIT]I used this instead

NewsletterId = Right(NewsletterId, (Len(NewsletterId) -2))

and it works great [EDIT]

-----------------------------------------------------------
"Don't follow someone who's not going anywhere" John Mason