The array seems to work fine and it only sent it to the top 5 which I wanted but I checked the DB and the Mailsent are all still set to 0. Won't this statement update the databse? I want to make sure that it is working before I try sending it to all.
Does this have to go inside my loop as well?

Dim SQL
SQL = "UPDATE ORNewsletterTest SET Mailsent=1 WHERE NewsletterId IN (" & NewsletterId & ")"

-----------------------------------------------------------
"Don't follow someone who's not going anywhere" John Mason

Are you sure you're executing the code? Did you take out the Response.End part?

If that doesn't help, can you post the relevant code for the database update? And the output of the Response.Write statement.

Cheers,

Imar
---------------------------------------
Imar Spaanjaars
Everyone is unique, except for me.

Dim SQL2
    SQL2= "Update ORNewsletterTest set Mailsent=1 where NewsletterId in (" & NewsletterId & ")"

    Response.Write(SQL2)

I have this code after the loop and it seems to hold the proper data
SQL2=Update ORNewsletterTest set Mailsent=1 where NewsletterId in (1, 2, 3, 4, 5)

But I always use a statment like this to update a database, but I don't know how to make it work with an array.

    SQLStr="SELECT * FROM ORNewsletter where NewsletterId in (" & NewsletterId & ")"
        RS.Open SQLStr,Application("DBConn"),1,2,&H0001

        RS("NewsletterId")= NewsletterId
        RS.Update

-----------------------------------------------------------
"Don't follow someone who's not going anywhere" John Mason

Ah, that explains a lot.

The easiest way to do that is to use the Execute method of the connection object:Take a look at the ADO Programmer's Guide. There is a lot of useful information in there: http://msdn.microsoft.com/library/en...mmersguide.asp

Cheers,

Imar
---------------------------------------
Imar Spaanjaars
Everyone is unique, except for me.

Yes Morpheus,

You already would have a connection object initialized. So you got to just add this EXECUTE thing next to your SQL2 statement to get those rows updated with mailsent=1

The statement in blue was not in your code, so you weren't able to update all those rows that were processed for newsletter.

I think you are almost done with it, just this step to go.
Cheers!

_________________________
-Vijay G
Strive for Perfection

    SQL2= "Update ORNewsletterTest set Mailsent=1 where NewsletterId in (" & NewsletterId & ")"


    Dim oConn
    Set oConn = Server.CreateObject("ADODB.Connection")
    oConn.Open SQL2, oConn, 1, 2, &H0001
    oConn.Execute(SQL2)
    oConn.Close
    Set oConn = Nothing

Microsoft VBScript runtime error '800a01c2'

Wrong number of arguments or invalid property assignment: 'Open'

Can you explain why I am getting this error? I am not sure what to do , do I need a recordset object as well or does this look right to you?

Thanks

-----------------------------------------------------------
"Don't follow someone who's not going anywhere" John Mason

No, you don't. You can use the exact code I gave you:All you need to do is change the YourConnectionStringHere variable to a valid connection string. There is no point in passing a connection object to the Open method of a Connection ;)

Imar

Here is the example I got from the MSDN library

Dim oConn As ADODB.Connection
Dim oRs As ADODB.Recordset
Dim sConn As String
Dim sSQL as String

sConn = "Provider='SQLOLEDB';Data Source='MySqlServer';" & _
          "Initial Catalog='Northwind';Integrated Security='SSPI';"

' Open a connection.
Set oConn = New ADODB.Connection
oConn.Open sConn

' Make a query over the connection.
sSQL = "SELECT ProductID, ProductName, CategoryID, UnitPrice " & _
             "FROM Products"
Set oRs = New ADODB.Recordset
oRs.Open sSQL, oConn, adOpenStatic, adLockBatchOptimistic, adCmdText

MsgBox oRs.RecordCount

' Close the connection.
oConn.Close
Set oConn = Nothing

The blue line is opening the recordset, but I want to just open the connection and execute the sql.

Do I need the red line as well, because once I log in the connection is made to the database. I am now gettting an error on this line

    oConn.Execute(SQL2)
that says

ADODB.Connection error '800a0e78'

Operation is not allowed when the object is closed




-----------------------------------------------------------
"Don't follow someone who's not going anywhere" John Mason

I'll be more than happy to repeat the same stuff over and over again ;)
You don't need a recordset; all you need is my code with a suitable connection string. Since you're not retrieving records (you're using an UPDATE statement and not a SELECT statement, there is nothing to store in a recordset. The Execute method of the Connection object (see the link to the MSDN documentation I gave you earlier), just executes a SQL command you pass it. You are confusing connection objects (oConn in my example) with connection strings (YourConnectionStringHere in my example).

Try this:The connection string you posted (and that I reused) is probably not going to work. It points to a SQL server called MySqlServer with the "default" NorthWind database. You probably should get your own connection string from another page that already runs fine. Maybe you need an Access string, or a SQL Server string; depends on the database you're using.

May I suggest you get some good books about ASP, databases, T-SQL etc and do some reading? You could have finished this application last week if you'd done some research in relevant books. I don't mind helping people, but I do mind doing other people's work. With a better understanding of the basic principle behind web-based and database driven applications, things become much easier for you.
I am not trying to be rude; I also didn't give you up; I am just trying to give you some good suggestions.

Cheers,

Imar

Thanks Imar, I understand exactly what you are saying and I apperciate the time you take to help me :). I guess I just thought I understood it better than I did. I think I can handle the SQL side of it but the asp is new to me. What books for asp would you recomend? also would it be a great advantage for me to learn asp.net?

Thanks again for your help, you have been more than fair ;)

-----------------------------------------------------------
"Don't follow someone who's not going anywhere" John Mason